New props maybe ?
Khachatour opened this issue · 4 comments
Hey there! Awesome thing right here thanks!
Only one suggestion, what you think ? Maybe there can be showDirectorInfo
or something like that boolean prop to allow control visibility of Director
more easily ?
export default class extends React.PureComponent {
constructor(props) {
super(props);
props.showDirectorInfo && showDirector();
}
render() {
return this.props.children;
}
}
Good idea. Wanna send a PR?
It's better if the prop is negated like hideDebugger
so we can default it to false. Also we need to hide/show the Director when the prop changes in componentDidUpdate
.
Yes, sure :) I'll write it asap :)
@pomber Sorry for the very late reply. Today I eventually get my hands back to this awesome project. So after the initial run, I've encountered an error regarding flatmap-stream
and event-stream
it is now removed. It is the package which contained a security vulnerability. I want to inform you about this, and decide what to do 😄
I just tried a fresh clone and didn't get the error. When are you getting it?