pomerium/pomerium-helm

helm chart uses deprecated cache_service_url

tobiaskohlbau opened this issue · 1 comments

tobiaskohlbau commented

What happened?

The helm chart to deploy pomerium uses deprecated cache_service_url configuration option. This results in pomerium complaining at startup that this option will be removed in v0.11.0.

{"level":"warn","time":"2020-10-13T09:36:10Z","message":"config: cache url will be deprecated in v0.11.0"

What did you expect to happen?

Use replacement option databroker_service_url instead.

Steps to reproduce

  1. Deploy pomerium with helm chart.

What's your environment like?

  • Chart version: 12.5.0
  • Container image: v0.10.6
  • Kubernetes version: v1.19.0
  • Cloud provider: None
  • Other details:

Additional context

pomerium-helm/charts/pomerium/templates/_helpers.tpl

Line 406 in 47d9ff8

cache_service_url: {{ default (printf "%s://%s.%s.svc.cluster.local" (include "pomerium.httpTrafficPort.name" .) (include "pomerium.cache.fullname" .) .Release.Namespace ) .Values.authenticate.cacheServiceUrl}}

Should switch over to databroker_service_url.

tobiaskohlbau commented

Feel free to assign this issue to me. I will try to get the PR merged and will apply any requested changes.