Replace tests that evaluate stdout output
hasheddan opened this issue · 5 comments
Some of the integration tests evaluate that certain words are present in the stdout output, which can break or change with updates to the logging verbosity. The following tests specifically do this:
integration/update/empty-deps
integration/update/github-leaf
integration/fetch/empty-deps
integration/fetch/local-direct
integration/fetch/mutually-recursive
integration/fetch/self-referential
integration/fetch/local-git
integration/fetch/github-deep
integration/fetch/remote-gits
integration/help
integration/info
integration/run
integration/run/without-bundle
integration/version
See #137 for more information.
@SeanTAllen would you like for these checks to just be removed from all of these tests? In help / info / version we would essentially just be testing exit 0.
I'd like to replace the tests that are using output to determine if an action happened with creating tests that use test-doubles to verify the correction interactions like for example, these that I recently wrote:
https://github.com/ponylang/corral/pull/132/files
https://github.com/ponylang/corral/pull/134/files
Did some work on this today, learned a bunch from this commit (7f00b2b). Hoping to have some updates landing soon 👍
@hasheddan are you interested in working on this? if yes, i can add you as a "contributor" to the ponylang org which basically allows you to be assigned to issues and not much else, then I can assign you to this.
@SeanTAllen Definitely! Thanks 👍
ok @hasheddan once you accept the invite, you should be able to assign yourself as you will have "triage" level access to all the organization repos.