pop-os/gtk-theme

Update flatpak theme

jackpot51 opened this issue ยท 5 comments

The current flathub version of the theme does not support GTK4. Keep it in better sync with the master branch.

flathub/org.gtk.Gtk3theme.Pop#7 is a draft and could be updated.

This is high priority since a number of applications from the newly released GNOME 41 will be using GTK4.

@jackpot51 GNOME Applications (or any other GTK4 applications) installed from Flathub are not picking up the test builds of the Theme in Flathub using GTK4. The Flatpak theming system doesn't appear to use the GTK4 extensions present in the theme, and it's not entirely clear how a GTK4 theme needs to work because there aren't currently any GTK4 compatible themes on flathub (and the documentation for Flatpak doesn't list anything for GTK4 themes, only GTK3 and GTK2.

The test build can currently be installed using flatpak install --user https://dl.flathub.org/build-repo/60736/org.gtk.Gtk3theme.Pop.flatpakref. I'm testing with Polari, its developers have stated that it uses GTK4 but not LibAdwaita.

Please fix this issue ๐Ÿ™๐Ÿ™๐Ÿ™๐Ÿ™. Adwaita in GTK4 looks terrible with the rest of Pop OS apps, its using rounded windows

bbhtt commented

and it's not entirely clear how a GTK4 theme needs to work because there aren't currently any GTK4 compatible themes on flathub (and the documentation for Flatpak doesn't list anything for GTK4 themes, only GTK3 and GTK2.

The runtime needs to create a separate extension point for GTK4 themes. Only Gtk3 themes have extension now

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/27825ba8d7720efe30d9f88650edcb88fd8a1c1e/elements/flatpak-images/platform.bst#L78

https://gitlab.gnome.org/GNOME/gnome-build-meta/-/blob/89623727ce7add26697e33ee0bc9ece077affa1f/elements/flatpak/platform.bst#L75

Then you can create a separate package like org.gtk.Gtk4theme.THEME

See also the above comment.

Edit. Follow https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/697, https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1620