pop-os/keyboard-configurator

Feature request: support for FN lock key in System76 Open EC

leviport opened this issue · 5 comments

Since system76/ec#263 is looking pretty good, it would be good to expose the key in system76-keyboard-configurator so users can map it once EC versions with the feature start making their way around.

Now that I think about it, exposing the Fn Lock button before EC supports it might be asking for trouble. I wonder if there's a way to conditionally show it based on the EC's release date.

Yeah. Adding a keycode is trivial but we probably want it to only appear of firmware versions supporting it.

Parsing the date is probably good enough if not theoretically ideal. The only case that would be an issue is if someone checks out and compiles an older EC firmware.

I guess we can do this once EC firmware with that change is released, based on the date of that release.

Firmware 2023-08-01_ec529da and newer has support for a FnLock key.

vbatts commented

update just landed on my lemp9 and works like a charm. Thanks, all