Add activate hooks
Closed this issue · 5 comments
Hi, I want to suggest to add the following hooks:
venv-pre-activate-hooks
venv-post-activate-hooks
venv-pre-deactivate-hooks
venv-post-deactivate-hooks
Is there something you need to do that can't be done by advising the relevant functions?: https://github.com/porterjamesj/virtualenvwrapper.el#advising
In general I'd like to avoid adding features if it can already be done with stuff that already comes in Emacs.
Although I suppose hooks are a built in part of Emacs also. Hmmm I'm pretty busy for the next few days so I probably won't get to it, but I will think about it.
Certainly, you can achieve the same features advising functions, but (IMHO) in this case hooks are a better option than advising.
p.d.: Maybe I can make a pull request later :)
Yeah I think there's a definite argument that hooks would be better. A PR would be great :)
closed by #13