Protect master branch
okonet opened this issue · 5 comments
I've accidentally pushed to master. Although it was my fault, I think we should not allow that and enforce PRs by protecting the master branch: https://help.github.com/articles/configuring-protected-branches/
It is protected, but admins can still push, so we don't have to go through a PR with LGTM for a simple typo fix etc.
Makes sense
Sincerely yours
Andrey Okonetchnikov
@okonetchnikov
http://okonet.ru
On 15. Februar 2016 at 18:55:04, max stoiber (notifications@github.com)
wrote:
It is protected, but admins can still push, so we don't have to go through
a PR with LGTM for a simple typo fix etc.—
Reply to this email directly or view it on GitHub
#177 (comment)
.
Yeah that's correct, you have write access. We trust you 😉
nvm, let me fix this. It's my mess. It should be resolved any minute