postgres-plr/plr

Fix the pgcrypto position error in the Windows build that uses pg master

AndreMikulec opened this issue · 2 comments

The error is here.
https://ci.appveyor.com/project/davecramer/plr-lek5y/builds/41423726/job/tlaw5ghh8sgqun86?fullLog=true#L91

Everything about pgcrypto was removed in this commit affecting the file src/tools/msvc/Mkvcbuild.pm
postgres/postgres@db7d1a7#diff-fd3a59b81739e0c9f354d679334926ecfc23defb2b3d477f9d22f182adb19afe

To fix this error, in the file src/tools/msvc/Mkvcbuild.pm, detect if the pgcrypto code does not exist,
then, if true, insert the Perl code that creates the MSVC plr project to the positon that is before(above) the line

foreach my $subdir ('contrib', 'src/test/modules')

instead of to position that is after(below) pgcrypto.

A pull request with this fix will be submitted.

Dave,

Your Appveyor builds have all succeeded
(including all pg master and pg versions on Windows).

Issue 127 Fix the pgcrypto position error in the Windows build that uses pg master PULL #128

Issue 127 Fix the pgcrypto position error in the Windows build that uses pg master
https://ci.appveyor.com/project/davecramer/plr-lek5y/builds/41988323

closed with #128