postgrespro/pgsphere

Add BRIN support for spoint and sbox?

Closed this issue · 3 comments

esabol commented

Would incorporating this PR be useful to anyone? It was fully working but never merged. It seems a waste to not retain this functionality, and it could be a real benefit when dealing with very large tables with millions of points.

See akorotkov/pgsphere#8 and this comment.

gbroccolo commented

Hi, I see @vitcpp already opened a PR here (will leave comments there eventually). I'm happy to help if needed.

  • 👍2
vitcpp commented

@gbroccolo Thank you for the patch! I preserved your authorship of the patch with some code adjustments. I believe, you don't mind if the patch will be applied in this repo. We also appreciate it if you will open some new PRs in this repo that seems to be the only alive repo of the pgSphere project.

  • 👍1
gbroccolo commented

Hi @vitcpp fine. Will try to open new PRs, each one for each spherical geometry, any sooner. I will probably start with the circular type, as requested by @esabol.

  • 👍2