postgrespro/rum

clang warns about unused variable in rum_ts_utils.c

Closed this issue · 5 comments

jmscott commented

clang warns about the unused variable 'extra_data' at line 722 in rum_ts_utils.c. adding a void cast of extra_data will safely silence the warning.

(void)extra_data

or just remove the declaration of 'extra_data'.

za-arthur commented

Thank you for the issue! It was fixed.

Repository was updated. A lot of changes were done. For example, operator <-> was renamed to <=>, index is built faster.

jmscott commented

will test today ... on a 6 million page database.

thanks for the hard work-john

On Tue, Aug 2, 2016 at 7:50 AM, Arthur notifications@github.com wrote:

Thank you for the issue! It was fixed.

Repository was updated. A lot of changes were done. For example, operator
<-> was renamed to <=>, index is built faster.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKDu0VxGZ0j-SKecDtRBQMLBp6sJmks5qbz0ugaJpZM4JZvmR
.

za-arthur commented

Excellent!
I close the issue.

jmscott commented

do i only rebuild the rum indexes?

On Tue, Aug 2, 2016 at 8:06 AM, Arthur notifications@github.com wrote:

Closed #3 #3.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKNXQl28VstMfyPB_OrRwRg7x5xTfks5qb0DBgaJpZM4JZvmR
.

za-arthur commented

For better testing you also need uninstall extension from your database with built indexes (because rum introduce new operators and operator classes now). After that quit psql (if you use it). Then:

  • build extension from sources
  • install extension to your database
  • build index.