Build error&warning on pg13.0: too few arguments: LogicalTapeSetCreate()

[jmscott]

getting both error and warning on build of pg13.0.
reproduced on minimal vm build of fedora 5.6.13 , as well as development mac catalina.

src/rumsort.c: In function ‘inittapes’:
src/rumsort.c:43:69: warning: passing argument 4 of ‘LogicalTapeSetCreate’ makes pointer from integer without a cast [-Wint-conversion]
43 | #define LogicalTapeSetCreate(X) LogicalTapeSetCreate(X, NULL, NULL, 1)
| ^
| |
| int
src/rumsort.c:1529:19: note: in expansion of macro ‘LogicalTapeSetCreate’
1529 | state->tapeset = LogicalTapeSetCreate(maxTapes);
| ^~~~~~~~~~~~~~~~~~~~
In file included from src/rumsort.c:25:
/home/jmscott/opt/postgres/pgsql-13.0/include/server/utils/logtape.h:57:24: note: expected ‘SharedFileSet *’ {aka ‘struct SharedFileSet *’} but argument is of type ‘int’
57 | extern LogicalTapeSet *LogicalTapeSetCreate(int ntapes, bool preallocate,
| ^~~~~~~~~~~~~~~~~~~~
src/rumsort.c:43:33: error: too few arguments to function ‘LogicalTapeSetCreate’
43 | #define LogicalTapeSetCreate(X) LogicalTapeSetCreate(X, NULL, NULL, 1)
| ^~~~~~~~~~~~~~~~~~~~
src/rumsort.c:1529:19: note: in expansion of macro ‘LogicalTapeSetCreate’
1529 | state->tapeset = LogicalTapeSetCreate(maxTapes);
| ^~~~~~~~~~~~~~~~~~~~
In file included from src/rumsort.c:25:
/home/jmscott/opt/postgres/pgsql-13.0/include/server/utils/logtape.h:57:24: note: declared here
57 | extern LogicalTapeSet *LogicalTapeSetCreate(int ntapes, bool preallocate,
| ^~~~~~~~~~~~~~~~~~~~
make: *** [: src/rumsort.o] Error 1

[jmscott]

appears rum not ready for pg13.