Directory cached_data_dir did not cleanup after test finished

Question

Directory cached_data_dir did not cleanup after test finished

sfalkon opened this issue 8 years ago · 5 comments

Answer 1 · 2017-10-24T09:00:50.000Z

Hi @sfalkon, good catch!

Answer 2 · 2017-10-24T09:23:11.000Z

@ildus, @zilder, I think we should remove cached_data_dir automatically, but it's hard to tell who should be responsible for this action. We could probably add a refcounter and do +1 in __enter__() and -1 in __exit__() of PostgresNode, but that would nullify all the benefits of such cache if only one instance of PostgresNode is active at any time.

Answer 3 · 2017-10-25T14:12:48.000Z

@funbringer yeah, we can't remove it on __exit__. First of all we will need it for the next node, and secondly user can start nodes without with blocks. I think we should use atexit handlers.

Answer 4 · 2017-10-25T23:01:32.000Z

Maybe, should user call "clean()" function manually?

Answer 5 · 2017-11-02T12:12:20.000Z

Fixed in 1.3.2.