PostgresNode.safe_psql(filename) does not detect syntax errors

Question

PostgresNode.safe_psql(filename) does not detect syntax errors

cbandy opened this issue 7 years ago · 6 comments

It took me some time to discover that a syntax error was being not being reported by node.safe_psql(filename='some.sql'). I tracked it down to behavior in psql. It seems worth raising, though I'm not certain it is something that testgres is necessarily responsible for handling.

$ psql --version
psql (PostgreSQL) 9.6.4

and/or

$ psql --version
psql (PostgreSQL) 10.4

psql reports errors differently depending on how input is passed:

$ psql -h 127.0.0.1 -U cbandy -X -A -t -q -c 'whoops' -p 34751 postgres ; echo $?
ERROR:  syntax error at or near "whoops"
LINE 1: whoops
        ^
1

N.B. exit code is zero here:

$ psql -h 127.0.0.1 -U cbandy -X -A -t -q -f <( echo 'whoops' ) -p 34751 postgres ; echo $?
psql:/dev/fd/63:1: ERROR:  syntax error at or near "whoops"
LINE 1: whoops
        ^
0

$ psql -h 127.0.0.1 -U cbandy -X -A -t -q -v ON_ERROR_STOP=1 -f <( echo 'whoops' ) -p 34751 
postgres ; echo $?
psql:/dev/fd/63:1: ERROR:  syntax error at or near "whoops"
LINE 1: whoops
        ^
3

Answer 1 · 2018-07-17T19:00:56.000Z

Hi Chris,

Thanks for the report! I'll definitely fix this.

Answer 2 · 2018-07-17T19:08:20.000Z

This is really odd, but we should provide a workaround nevertheless. I guess it's worth starting a thread in pgsql-hackers.

Answer 3 · 2018-07-17T19:49:18.000Z

ON_ERROR_STOP=1

Now the question is whether we should add this option to psql's args by default. I'd like to, but this might break some other user's expectations.

EDIT: at first I didn't notice you mentioning ON_ERROR_STOP.

Answer 4 · 2018-07-18T09:10:01.000Z

I suggest to change environment in safe_psql and keep old behavior in psql.

Answer 5 · 2018-07-18T13:22:51.000Z

Fixed in 1.8.2.

Answer 6 · 2018-07-18T15:00:35.000Z

Thank you for such a quick response!