v1.15.7 Code indiscrepancy? FitasBuspakje .... 2 timezones, same logic? several places
seansan opened this issue · 1 comments
seansan commented
in app/code/community/TIG/PostNL/Block/Adminhtml/Sales/Order/Shipment/Create/ShipmentOptions.php date is converted to Amsterdam time but the same logic in app/code/community/TIG/PostNL/Model/Core/Shipment.php is not
see difference in $deliveryDate->setTimezone(new DateTimeZone('Europe/Amsterdam'))
$deliveryDate = DateTime::createFromFormat(
'Y-m-d H:i:s',
$postnlOrder->getDeliveryDate(),
new DateTimeZone('UTC')
);
$deliveryDate->setTimezone(new DateTimeZone('Europe/Amsterdam'));
if ($deliveryDate->format('N') === '0' || $deliveryDate->format('N') === '1') {
return false;
}
tig-dennisvanderhammen commented
Hi Sean,
Thanks for the submission. I've created a backlog item for this issue. Once this has been looked into, we'll update this Github issue.