postnl/postnl-magento1-End-of-life

Duplicate start <li> tag

Closed this issue · 3 comments

Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running the latest version of the TIG PostNL Magento extension.

What is the purpose of your issue?

  • Feature request (request for a new functionality)
  • Bug report (encountered problems with the TIG PostNL Magento extension)
  • Extension support request (request for adding support for a new extension)
  • Other

If the purpose of your issue is a bug report

The two lines with <li class="clearfix"> on line 58 and 70 of app/design/frontend/base/default/template/TIG/PostNL/address_validation/onestepcheckout/postcod_check.phtml causes duplicate <li> opening tags as the opening tag is already outputed by billing_fields.phtml (in the same folder).

I will prepare a PR with a fix.

@MarcoMiltenburg thanks for letting us know. I see we didn't respond to this yet. I'll ask my colleague to take a look at it.

@tig-dennisvanderhammen could you take a look at this? This has been open for a while.

I replied on PR #46 and am currently waiting on a response. :)

I will close this issue due to no response for 2 months.