[BUG] The housenumber from custom tig field is not saved to the shipping info and billing address

Question

[BUG] The housenumber from custom tig field is not saved to the shipping info and billing address

glevhen opened this issue 2 years ago · 14 comments

The housenumber from custom tig field is not saved to the shipping info and billing address, so it's not shown in billing address and shipping address details on the checkout payment step

To Reproduce

Enable postcode check in the module settings and street lines qty to 3
Go to the checkout page and fill shipping info (the selected country should be NL), fill postcode and housenumber with any valid address values, for example 7418et and 7
press Next button and go to the payment step

Expected result
The housenumber should be showed in the billing address and shipping address details

Actual result
The housenumber should be showed in the billing address and shipping address details

Workaround
Describe the temporarily workaround or if none exists write "None"

Screenshots
the housenumber is filled on the shipping step

the housenumber is missing on the payment step in billing address details and shipping address info, only street info is showed

Magento version: [e.g. Magento 2.4.5]
PHP version: [e.g. 8.1]
TIG PostNL version: [e.g. 1.12.4]

Answer 1 · 2022-10-28T13:01:35.000Z

Hey @glevhen ,

I can reproduce this, so I will place this on the backlog. We are going to fix this, seems like it only a display problem because the order in the backend has a housenumber, but we will fix this. Thank you for submitting this.

Have a great day,
Jeffrey

Answer 2 · 2022-10-28T13:05:08.000Z

Hey @glevhen ,

I can reproduce this, so I will place this on the backlog. We are going to fix this, seems like it only a display problem because the order in the backend has a housenumber, but we will fix this. Thank you for submitting this.

Have a great day, Jeffrey

@tig-jeffreybranderhorst you are right about the housenumber in order info, there it is ok, please fix it for checkout payment step, thank you for quick confirming the issue.

Have a nice day

Answer 3 · 2022-11-02T17:12:22.000Z

I can reproduce this issue as well. There seems to be some problems in saving the street lines in the local storage. The checkout displays everything correctly but the house number and addition are not in the Local Storage.

Magento version: [e.g. Magento 2.4.5-p1]
PHP version: [e.g. 7.4]
TIG PostNL version: [e.g. 1.12.4]

Answer 4 · 2022-11-03T13:08:03.000Z

This seems to be because of the following commit: 94bb2e8

Can't really find a reason as to why these lines were removed, but adding back <text args="tigHouseNumber()"></text><br/> into details.html seems to work.

Haven't thoroughly tested this though, but wanted to share anyway.

Answer 5 · 2022-11-03T13:12:54.000Z

Hi @DavidBuro210 ,

Thank you for the update, I will place your comment in the backlog issue so it can be fixed.

Have a great day,
Jeffrey

Answer 6 · 2022-11-15T07:36:17.000Z

We are experiencing this aswell. Could it be given some higher priority since this makes guests in the checkout very unsure about their address information being entered/submitted correctly?

Answer 7 · 2022-11-15T08:09:40.000Z

Hi @jdereus87 ,

It will be in our next release, we hope to be able to release it this week. We are awaiting approval of PostNL for release because they are testing it.

Have a great day,
Jeffrey

Answer 8 · 2022-11-15T08:24:37.000Z

@Jeffrey-H is it possible to show the code for the fix? We could try to solve it temporarily in our project while waiting for the official release

Answer 9 · 2022-11-15T08:46:01.000Z

@Jeffrey-H is it possible to show the code for the fix? We could try to solve it temporarily in our project while waiting for the official release

@Aquive the only section I could fix is the one above the Terms and Conditions on the checkout page. For mobile users this will probably decrease the confusion but on desktop it's still in the order overview on the right.

tig_postnl_house_number_337.diff

Answer 10 · 2022-11-15T08:49:34.000Z

Thanks @Jeffrey-H I will look into it! I meant to tag @tig-jeffreybranderhorst to be honest, oops!

@tig-jeffreybranderhorst is it possible to show the code for the fix? We could try to solve it temporarily in our project while waiting for the official release.

Answer 11 · 2022-11-15T09:06:58.000Z

@Aquive the diff the posted by @Jeffrey-H (thanks!) tig_postnl_house_number_337.diff is the code that will be changed in v1.12.5 to fix the house number issue. It is actually a revert of an earlier change for when you have multiple postcode suggestion services installed.

@Aquive Was this what you where looking for to temporary fix the issue?

Answer 12 · 2022-11-15T12:00:36.000Z

I have tested making a patch with the diff file from Robert and running a before & after test.

Running that file as a patch does indeed restore the front view in the summary of the housenumber.
However for foreign countries (lets say Belgium for ease) it then does not register the street address correctly in the billing address on the order view (backend). The street field as a whole is missing.

So with the patch we get:

Working view of the dutch housenumber on the checkout summary

We lose the correct registration of the billing address street fields

Without it:

We lose the view of the housenumber on the dutch summary view of the checkout

We get a correct registration of the billing address on belgian orders.

For now we will do it without the patch and have put a disclaimer below the ship-via container in the checkout summary.

Tested:
Magento 2.4.4
PostNL: 1.12.4
Native checkout

Answer 13 · 2022-11-17T12:16:44.000Z

Hey @jdereus87 ,

Yesterday we released a new PostNL version where this is fixed.

Have a great day,
Jeffrey

Answer 14 · 2022-11-17T12:58:47.000Z

@tig-jeffreybranderhorst
Thank you! I will take a look at it next week.