BlockEval doesn't distinguish between overlay() not being implemented and overlay() throwing an error

When BlockEval calls a block's overlay() to get any custom updates for the block's display, it's done inside a try-catch that ignores the output on any error. However, the same behavior occurs if overlay() throws an exception or if it simply doesn't exist. In the case where the block throws an error inside overlay(), it would be helpful to log the error.

See here:

PothosFlow/EvalEngine/BlockEval.cpp

Line 286 in 25b689b

//the function may not exist, ignore error

Maybe i just need some good reflection support so the client class can ask if a block has an overlay. Or for that matter if any proxy object has a function, probably an addition to the proxy classes and their overloads.

That would be useful and a better way to do it in the long term than my pull request. It makes it tedious to figure some issues out, so maybe pull it in with a TODO?

…

On Mar 7, 2020, at 09:25, Josh Blum ***@***.***> wrote: Maybe i just need some good reflection support so the client class can ask if a block has an overlay. Or for that matter if any proxy object has a function, probably an addition to the proxy classes and their overloads. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.