potionfactory/LetsMove

Problem with "xattr -r" on 10.5

Closed this issue · 1 comments

The -r flag should not be present when calling xattr on 10.5. Currently on 10.5 the call is doing nothing, because xattr is balking at the -r flag.

I'm guessing this is simply a mistake and the code has it is the wrong way round, setting -r for 10.5 and not for 10.6, when it should be vice versa.

This does, however, raise the question of why -r would be needed on 10.6, since it's not being used for 10.6 at the moment and things seem to be working?

Yeah, the flag was set the other way around. I'm not sure if the -r is needed on 10.6 but the code was submitted to me that way. I'm guessing that it might clear the attribute from sub-bundles. Even if that's not the case, it won't hurt anything, so I'll just keep it.