poulainv/tottem

Implement all cards component

poulainv opened this issue · 4 comments

poulainv commented

Implement cards component of those components

  • Movies
  • Article
  • Influencers
  • Podcast

Then add sample data to display those fixtures in profile!

poulainv commented

All pictograms are already committed!

  • 👍1
deonclem commented

This is the kind of model definition I had in mind:

image

Any collection should have a type, and we should instantiate its items based on it.

Wdyt?

Also, the "maximum 1 class per file" tslint rule is dumb imo, this isn't Java 😄

poulainv commented

I commented your commit. I am not fan of those definition as it's really verbose (a bit java style) and define styling (rounded, small, big) inside data... while we rather should use types to decide how we want to display data into card!

poulainv commented

Actually, I am not sure that we want different types for now. Maybe

{
    title: string
    author: string
    url: string
    imageUrl: string
    type: 'podcast' | 'movie' | 'album' ...
}

is enough ... because I don't see any use cases to have spotifyUrl | amazonUrl! Maybe we can simplify