Add ability to upload Pages, Numbers, and Keynote files with the File Upload kit [NUXE-950]
stevelandwehr opened this issue · 8 comments
Is your feature request related to a problem? Please describe.
The File Upload kit doesn't support uploading Pages, Numbers, or Keynote files even though their file types are being passed in the accept prop. The file types I've tried passing are:
- application/vnd.apple.keynote
- application/vnd.apple.numbers
- application/vnd.apple.pages
- application/x-iwork-keynote-sffkey
- application/x-iwork-pages-sffpages
- application/x-iwork-numbers-sffnumbers
Describe the solution you'd like
I'd like to be able to use the File Upload kit to upload Pages, Numbers, and Keynote files.
Describe alternatives you've considered
We've considered, and are currently implementing, using react-dropzone to upload files.
@stevelandwehr sorry, Just now looking at this. Be sure and ping the playbook channel when you add these so we make sure everyone sees them.
@stevelandwehr Where are you passing the accepted file type to dropzone?...or are you just accepting all for now? https://github.com/powerhome/nitro-web/pull/21459/files#diff-11faae29eb5bb0ab5c2aa946a424c0742aee91c1a60d4f794f9bcc819738b554R70
Based on the source the accept prop should simply be passed through
@stevelandwehr Where are you passing the accepted file type to dropzone?...or are you just accepting all for now? https://github.com/powerhome/nitro-web/pull/21459/files#diff-11faae29eb5bb0ab5c2aa946a424c0742aee91c1a60d4f794f9bcc819738b554R70
Just accepting all for now.
@stevelandwehr Hi Steve! I spoke with Kevin last week and it sounded like this does not block work for BoP; is that correct? I'm going to add this to our backlog in Runway-- it might get wrapped up into some other File Upload Kit work soon, but if this doesn't block any work, we may not end up prioritizing fixing this.
@stevelandwehr Hi Steve! I spoke with Kevin last week and it sounded like this does not block work for BoP; is that correct? I'm going to add this to our backlog in Runway-- it might get wrapped up into some other File Upload Kit work soon, but if this doesn't block any work, we may not end up prioritizing fixing this.
Hi Samantha. No, this is not currently blocking anything for BoP.
This is now tracked in Runway as NUXE-950.
Closing as this is now in master