getting error while executing the script
Closed this issue · 1 comments
amy201988 commented
below is the code i modified:
import boto3
import collections
import datetime
import csv
from time import gmtime, strftime
import smtplib
from email.MIMEMultipart import MIMEMultipart
from email.MIMEBase import MIMEBase
from email.MIMEText import MIMEText
from email import Encoders
import os
EC2 connection beginning
ec = boto3.client('ec2')
S3 connection beginning
s3 = boto3.resource('s3')
lambda function beginning
def lambda_handler(event, context):
#get to the curren date
date_fmt = strftime("%Y_%m_%d", gmtime())
#Give your file path
filepath ='/tmp/PUC_AWS_Resources_' + date_fmt + '.csv'
#Give your filename
filename ='PUC_AWS_Resources_' + date_fmt + '.csv'
csv_file = open(filepath,'w+')
#boto3 library ec2 API describe region page
#http://boto3.readthedocs.org/en/latest/reference/services/ec2.html#EC2.Client.describe_regions
regions = ec.describe_regions().get('Regions',[] )
for region in regions:
reg=region['RegionName']
regname='REGION :' + reg
#EC2 connection beginning
ec2con = boto3.client('ec2',region_name=reg)
#boto3 library ec2 API describe instance page
#http://boto3.readthedocs.org/en/latest/reference/services/ec2.html#EC2.Client.describe_instances
reservations = ec2con.describe_instances().get(
'Reservations',[]
)
instances = sum(
[
[i for i in r['Instances']]
for r in reservations
], [])
instanceslist = len(instances)
if instanceslist > 0:
csv_file.write("%s,%s,%s,%s,%s,%s\n"%('','','','','',''))
csv_file.write("%s,%s\n"%('EC2 INSTANCE',regname))
csv_file.write("%s,%s,%s,%s,%s,%s\n"%('InstanceID','Instance_State','InstanceName','Instance_Type','LaunchTime','Instance_Placement'))
csv_file.flush()
for instance in instances:
state=instance['State']['Name']
if state =='running':
for tags in instance['Tags']:
Instancename= tags['Value']
key= tags['Key']
if key == 'Name' :
instanceid=instance['InstanceId']
instancetype=instance['InstanceType']
launchtime =instance['LaunchTime']
Placement=instance['Placement']['AvailabilityZone']
csv_file.write("%s,%s,%s,%s,%s,%s\n"% (instanceid,state,Instancename,instancetype,launchtime,Placement))
csv_file.flush()
for instance in instances:
state=instance['State']['Name']
if state =='stopped':
for tags in instance['Tags']:
Instancename= tags['Value']
key= tags['Key']
if key == 'Name' :
instanceid=instance['InstanceId']
instancetype=instance['InstanceType']
launchtime =instance['LaunchTime']
Placement=instance['Placement']['AvailabilityZone']
csv_file.write("%s,%s,%s,%s,%s,%s\n"%(instanceid,state,Instancename,instancetype,launchtime,Placement))
csv_file.flush()
#boto3 library ec2 API describe volumes page
#http://boto3.readthedocs.org/en/latest/reference/services/ec2.html#EC2.Client.describe_volumes
ec2volumes = ec2con.describe_volumes().get('Volumes',[])
volumes = sum(
[
[i for i in r['Attachments']]
for r in ec2volumes
], [])
volumeslist = len(volumes)
if volumeslist > 0:
csv_file.write("%s,%s,%s,%s\n"%('','','',''))
csv_file.write("%s,%s\n"%('EBS Volume',regname))
csv_file.write("%s,%s,%s,%s\n"%('VolumeId','InstanceId','AttachTime','State'))
csv_file.flush()
for volume in volumes:
VolumeId=volume['VolumeId']
InstanceId=volume['InstanceId']
State=volume['State']
AttachTime=volume['AttachTime']
csv_file.write("%s,%s,%s,%s\n" % (VolumeId,InstanceId,AttachTime,State))
csv_file.flush()
#Give your owner ID
account_ids='753227428434'
#boto3 library ec2 API describe snapshots page
#http://boto3.readthedocs.org/en/latest/reference/services/ec2.html#EC2.Client.describe_snapshots
ec2snapshot = ec2con.describe_snapshots(OwnerIds=[
account_ids,
],).get('Snapshots',[])
ec2snapshotlist = len(ec2snapshot)
if ec2snapshotlist > 0:
csv_file.write("%s,%s,%s,%s\n" % ('','','',''))
csv_file.write("%s,%s\n"%('EC2 SNAPSHOT',regname))
csv_file.write("%s,%s,%s,%s\n" % ('SnapshotId','VolumeId','StartTime','VolumeSize'))
csv_file.flush()
for snapshots in ec2snapshot:
SnapshotId=snapshots['SnapshotId']
VolumeId=snapshots['VolumeId']
StartTime=snapshots['StartTime']
VolumeSize=snapshots['VolumeSize']
csv_file.write("%s,%s,%s,%s\n" % (SnapshotId,VolumeId,StartTime,VolumeSize))
csv_file.flush()
#boto3 library ec2 API describe addresses page
#http://boto3.readthedocs.org/en/latest/reference/services/ec2.html#EC2.Client.describe_addresses
addresses = ec2con.describe_addresses().get('Addresses',[] )
addresseslist = len(addresses)
if addresseslist > 0:
csv_file.write("%s,%s,%s,%s,%s\n"%('','','','',''))
csv_file.write("%s,%s\n"%('EIPS INSTANCE',regname))
csv_file.write("%s,%s,%s\n"%('PublicIp','AllocationId','Domain'))
csv_file.flush()
for address in addresses:
PublicIp=address['PublicIp']
AllocationId=address['AllocationId']
Domain=address['Domain']
csv_file.write("%s,%s,%s\n"%(PublicIp,AllocationId,Domain))
csv_file.flush()
#RDS Connection beginning
rdscon = boto3.client('rds',region_name=reg)
#boto3 library RDS API describe db instances page
#http://boto3.readthedocs.org/en/latest/reference/services/rds.html#RDS.Client.describe_db_instances
rdb = rdscon.describe_db_instances().get(
'DBInstances',[]
)
rdblist = len(rdb)
if rdblist > 0:
csv_file.write("%s,%s,%s,%s\n" %('','','',''))
csv_file.write("%s,%s\n"%('RDS INSTANCE',regname))
csv_file.write("%s,%s,%s,%s\n" %('DBInstanceIdentifier','DBInstanceStatus','DBName','DBInstanceClass'))
csv_file.flush()
for dbinstance in rdb:
DBInstanceIdentifier = dbinstance['DBInstanceIdentifier']
DBInstanceClass = dbinstance['DBInstanceClass']
DBInstanceStatus = dbinstance['DBInstanceStatus']
DBName = dbinstance['DBName']
csv_file.write("%s,%s,%s,%s\n" %(DBInstanceIdentifier,DBInstanceStatus,DBName,DBInstanceClass))
csv_file.flush()
ses_user = "AKIAICP6KWEKRM7X3GTA"
ses_pwd = "Ar9WyrfiTUtG376GFndoOGSyTeNIrXm0tPpec+fHWy+J"
def mail(fromadd,to, subject, text, attach):
msg = MIMEMultipart()
msg['From'] = fromadd
msg['To'] = to
msg['Subject'] = subject
msg.attach(MIMEText(text))
part = MIMEBase('application', 'octet-stream')
part.set_payload(open(attach, 'rb').read())
Encoders.encode_base64(part)
part.add_header('Content-Disposition','attachment; filename="%s"' % os.path.basename(attach))
msg.attach(part)
mailServer = smtplib.SMTP("email-smtp.us-east-1.amazonaws.com", 587)
mailServer.ehlo()
mailServer.starttls()
mailServer.ehlo()
mailServer.login(ses_user, ses_pwd)
mailServer.sendmail(fromadd, to, msg.as_string())
# Should be mailServer.quit(), but that crashes...
mailServer.close()
date_fmt = strftime("%Y_%m_%d", gmtime())
#Give your file path
filepath ='/tmp/PUC_AWS_Resources_' + date_fmt + '.csv'
#Give your filename
mail("Amritha.Sanath@in.pega.com","PegaCloud AWS Resources","PFA for the AWS resource of pegacloud account.",filepath)
s3.Object('pega-inventory', filename).put(Body=open(filepath, 'rb'))
and while testing this function i am getting below error:
{
"stackTrace": [
[
"/var/task/lambda_function.py",
56,
"lambda_handler",
"for tags in instance['Tags']:"
]
],
"errorType": "KeyError",
"errorMessage": "'Tags'"
}
nestoru commented
You instance has no tags. While this is a bug I would not fix it because to me at least one Tag should be mandatory (Name). Name your instances and that will take care of it. If you are modifying code it would be great to fork it and show your diff or even better perform a pull request.