Please modify the build script a/apicurio-registry/apicurio-registry_rhel8.sh
Opened this issue · 7 comments
- Has the embedded patch in the build script pushed upstream?
- Is the patch dependent on a specific grpc-java version? if yes, please modify the "git clone.."
- Isolate the path in a separate file
- Include a grpc-java build Dockerfile (preferably base on a rh_ubi image)
Use a/apicurio-registry/apicurio-registry_rhel8.sh as a reference.
@shirodkara please address / respond
1. Has the embedded patch in the build script pushed upstream?
No this hasn't been pushed upstream
2. Is the patch dependent on a specific grpc-java version? if yes, please modify the "git clone.."
this isn't for a specific version , but yes using a version is a better, will add the version to the "git clone.."
The change done was because on RHEL8 there is no libstdc++-static available (more info here : https://access.redhat.com/articles/rhel8-abi-compatibility in the section "Static Linking with the C/C++ Runtime")
@shirodkara can you clarify why this patch wasn't pushed upstream? It seems like it should be?
Based on grpc/grpc-java#7757 it looked like they needed static linking for protobuf for most platforms.
Nevertheless , I have asked them whether we can upstream this , if they confirm , I'll raise a PR for this.
@shirodkara could you add a condition check in your patch similar to:
if (System.getProperty('os.arch').contains('ppc64')){
linker.args "-Wl,-Bstatic", "-lprotoc", "-lprotobuf", "-static-libgcc",
"-Wl,-Bdynamic", "-lpthread", "-s"
} else {
linker.args "-Wl,-Bstatic", "-lprotoc", "-lprotobuf", "-static-libgcc",
"-static-libstdc++",
"-Wl,-Bdynamic", "-lpthread", "-s"
}
@shirodkara Any progress on this one? Seems like @afsanjar 's solution is simple enough?
The changes mentioned above were upstreamed to grpc-java as part of grpc/grpc-java@a6d78c5