pplu/aws-sdk-perl

'InvalidContent' vs 'ConnectionError'

eserte opened this issue · 4 comments

eserte commented

t/14_dns_client_errors.t fails on some of my smoker systems:

#   Failed test 'Correct code ConnectionError code'
#   at t/14_dns_client_errors.t line 29.
#          got: 'InvalidContent'
#     expected: 'ConnectionError'
# LWP caller
# Mojo caller

#   Failed test 'Correct code ConnectionError code'
#   at t/14_dns_client_errors.t line 70.
#          got: 'InvalidContent'
#     expected: 'ConnectionError'
# Furl caller
# Looks like you failed 2 tests of 8.
t/14_dns_client_errors.t ................ 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/8 subtests
eserte commented

Very probably the reason is the presence of wildcard DNS records on these systems. See also tokuhirom/Furl#128 for more information about this.

Without checking it, the usual fix is to add a dot to the invalid DNS name to make sure that it is not expanded. To simulate a possibly problematic system, one can set on Linux systems the LOCALDOMAIN environment variable to a domain using wildcard DNS records (in the past, bing.com or opensuse.de could be used for this).

castaway commented

ah thanks! I was just trying to figure out what was going on..

castaway commented

Hmm, sadly this works on 2/3 of 14_dns_client_errors.t, but not the first one

eserte commented

Do you have a diff or so? I could try it on my systems.