prabhakar267/WA-Reader

Strict file naming convention

Opened this issue · 2 comments

nannib commented

hi,
first of all thanks for your work!
bugs list:

  1. The TXT file must be named _chat.txt
  2. The attachments must be renamed (Datei angehängt), in Italian is (file allegato), in others languages will be different from Datei angehängt, so if you don't rename you cannot see the multimedia files.
  3. If you upload the zip file, the chat doesn't scroll down.
    Thank you again
prabhakar267 commented

Thanks @nannib for pointing this out. Please feel free to open a PR addressing these issues.

uptoratlen commented

some remarks (and split this up in three single tasks or sub tasks, maybe ? see last lines of this comment)
to 1) yep that is not so clever as pointed already out during implementation #78. Some code to find a text file with a correct format (in case multiple text files in zip) would be nice to have. Like get all text files, check for a WA format and than use that one file. In case someone puts more than one chat file in a zip, ok his fault.

to 2) @prabhakar267 already implemented some thing let's say "extendable". see "constants.py**". As far as I see, at that time (maybe now) there is no WA export definition. It varies from language to language and OS. The idea is as far as I understood, some users are able to provide something like French, and someone else adds it to the constants.py, right?
Or (!) in case there is such a definition of WA, post the link and we could add it to the file in one rush.
@prabhakar267 : please correct me if I'm wrong on the intention.

to 3) Your expectation is that after the chat is displayed, the chat should scroll down to the newest entry, right? Maybe a option checkbox near the "get conversation" button to select the scroll. Actually I like the oldest on top. Please correct me in case I got it wrong.

(and topic 3 is more or less independent form the first 2, that's why I mentioned the split. But just a opinion from me, not offensive)