prabirshrestha/asyncomplete.vim

set g:asyncomplete_auto_completeopt default to 0

squm opened this issue · 6 comments

squm commented

You added g:asyncomplete_auto_completeopt which overrides completeopt vim settings, it took time to figure out what messes with settings. Don't do this anymore, add new “features” with default value of “0”

I think the option is needed.
Because if completeopt is not set properly, the auto completion doesn't work.

You should not change the value if don't understand about completeopt.

I also think this shouldn't be set by default. It should respect completeopt of the user.

It actually broke <cr> because of noselect and I couldn't select the first suggestion. I almost gave up on this plugin just because of this. I think users can decide on their own how they want to set completeopt. If its necessary to function correctly then write it in the readme and say that the user needs to set completeopt accordingly.

It should respect completeopt of the user.

completeopt should be respented, yes. But if user's completeopt does not work with auto complete plugin, the plugin must change completeopt unfortunately.

I think users can decide on their own how they want to set completeopt.

You can change the behavior by g:asyncomplete_auto_completeopt option.

g:asyncomplete_auto_completeopt *g:asyncomplete_auto_completeopt*

Hm... It seems fixed option overwrite behavior, I think deoplete behavior is better though.
It does not overwrite noselect,noinsert if not needed.

Hm... It seems fixed option overwrite behavior, I think deoplete behavior is better though.
It does not overwrite noselect,noinsert if not needed.

Yes it should not overwrite those settings. Otherwise, it can lead to a lot of confusion. In this respect deoplete works better. I think the middleground here is to enforce certain settings which are needed for the completion to work, but to respect other settings like noselect and noinsert.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.