GHES support

Question

GHES support

emilva opened this issue 2 years ago · 6 comments

emilva commented 2 years ago

Hello, this looks like an awesome tool!

Is it possible to add a cli flag for github api url? That would enable support for GitHub Enterprise Server :)

Cheers,

emil

Answer 1 · 2023-02-06T19:33:29.000Z

Hello, thanks for checking it out!

We can most definitely add an experimental flag for supporting GHES. Our only concern, and the reason for not including it in the first place, is that we haven't had the opportunity to test Gato against an Enterprise instance. With some potential differences in the GHES API and the Github.com API, we would greatly appreciate any feedback/pr's addressing issues/gaps identified. I'll work on adding that shortly and reference here.

Thanks!

Answer 2 · 2023-02-06T20:04:24.000Z

Cool!

I can happily test it against our instance :)

There is usually some lag with regards to new features landing in GHES, but all old and stable features should co-exists in the GHES API too.

I am not very savvy with Python, but I would deffo help out with PR if I were :)

Thanks,

emil

Answer 3 · 2023-02-06T20:07:41.000Z

@emilva
Please give #12 a shot and let us know if you run into any issues. Thank you so much!

Answer 4 · 2023-02-16T05:24:40.000Z

Hello @emilva!

Have you been able to give this a shot against your GHES instance? Any feedback would be greatly appreciated!

Answer 5 · 2023-02-20T11:11:03.000Z

@mas0nd hey and sorry for the late response, was at a conference last week.

I will give this a go today.

Thanks,

emil

Answer 6 · 2023-05-18T19:21:09.000Z

The feature is now in the development branch, closing this issue.