pragtical/terminal

bug: opening terminal crashes Pragtical

Closed this issue · 5 comments

when i try to open the terminal with Terminal: Toggle Drawer (Alt+T), it pops up this message and then crashes:
image

error.txt contents
Error: /home/*****/.config/pragtical/plugins/terminal/init.lua:279: bad argument #1 to 'band' (number expected, got nil)

stack traceback:
	[C]: in function 'band'
	/home/*****/.config/pragtical/plugins/terminal/init.lua:279: in function 'draw'
	/usr/share/pragtical/core/node.lua:616: in function </usr/share/pragtical/core/node.lua:609>
	/usr/share/pragtical/core/node.lua:31: in function 'propagate'
	/usr/share/pragtical/core/node.lua:621: in function </usr/share/pragtical/core/node.lua:609>
	/usr/share/pragtical/core/node.lua:30: in function 'propagate'
	/usr/share/pragtical/core/node.lua:621: in function </usr/share/pragtical/core/node.lua:609>
	/usr/share/pragtical/core/node.lua:30: in function 'propagate'
	...
	/usr/share/pragtical/plugins/treeview.lua:596: in function 'root_view_draw'
	/usr/share/pragtical/plugins/contextmenu.lua:32: in function 'root_view_draw'
	/home/*****/.config/pragtical/plugins/lsp/listbox.lua:519: in function 'draw'
	/usr/share/pragtical/core/init.lua:1208: in function 'step'
	/usr/share/pragtical/core/init.lua:1290: in function 'core_run'
	/usr/share/pragtical/plugins/settings.lua:1912: in function 'core_run'
	/usr/share/pragtical/plugins/ipc.lua:852: in function 'run'
	[string "local core..."]:15: in function <[string "local core..."]:6>
	[C]: in function 'xpcall'
	[string "local core..."]:6: in main chunk
installed plugins
           align_carets |        0.1 |     plugin |          3 | installed
             autoinsert |        0.2 |     plugin |          3 | installed
               autosave |        0.1 |     plugin |          3 | installed
                  build |        0.1 |     plugin |          3 | installed
              centerdoc |        0.1 |     plugin |          3 | installed
               codeplus |        0.1 |     plugin |          3 | installed
           colorpreview |        0.2 |     plugin |          3 | installed
               debugger |        0.1 |     plugin |          3 | installed
       dragdropselected |        0.3 |     plugin |        3.1 | installed
                 exterm |        0.1 |     plugin |          3 | installed
      gitdiff_highlight |        0.1 |     plugin |          3 | installed
         indent_convert |        0.1 |     plugin |          3 | installed
            indentguide |        0.1 |     plugin |          3 | installed
                   json |        1.0 |    library |        n/a | installed
               lintplus |        0.3 |     plugin |          3 | installed
                    lsp |        0.6 |     plugin |        3.1 | installed
                  lsp_c |     16.0.2 |     plugin |          3 | installed
           lsp_snippets |          1 |     plugin |          3 | installed
                markers |        0.1 |     plugin |          3 | installed
                minimap |        0.2 |     plugin |          3 | installed
              nerdicons |        1.0 |     plugin |          3 | installed
         plugin_manager |        0.1 |     plugin |          3 | installed
            restoretabs |        0.1 |     plugin |          3 | installed
                    scm |        0.3 |     plugin |        3.1 | installed
     selectionhighlight |        0.2 |     plugin |          3 | installed
            smoothcaret |        0.3 |     plugin |        3.1 | installed
               snippets |          1 |     plugin |          3 | installed
          sticky_scroll |        1.0 |     plugin |          3 | installed
               terminal |        1.0 |     plugin |          3 | installed
jgmdev commented

Are you using the latest build of pragtical?

To run the terminal plugin some new changes are required like:

If you are on archlinux try the AUR pragtical-git package.

Edit:
I guess should make a pragtical release soon :)

i'll give it a try rq

it works perfectly! the issues are that:

  1. i have no idea how to use another shell (my user shell is bash, because i don't want my omz config with zsh in the tty), and i want to use zsh.
  2. it doesn't use my color scheme (which is understandable since it's xterm-256color).
  3. it doesn't work well with BLE on bash (zsh-autosuggestions equivalent)
jgmdev commented
  1. i have no idea how to use another shell

On you user module (init.lua) add something like:

core.add_thread(function()

if config.plugins.terminal then
  config.plugins.terminal.shell = "/usr/bin/zsh"
end

end)

Maybe we can patch the plugin to add Settings UI entries for easier configuration since they haven't been added upstream.

3. it doesn't work well with BLE on bash (zsh-autosuggestions equivalent)

This one may be reported upstream since this repo mainly focuses on making the plugin work with LuaJIT.

jgmdev commented

So latest release of Pragtical includes the necessary changes to make this plugin properly work and I also included Settings UI options to make it a bit easier to configure. Will close this issue now.