make: http.c:600:37: error: ‘ExtensionOidIndexId’ undeclared

[LeMerP]

Hey guys,

I get the following error(s) while compiling pgsql-http on a Ubuntu 20.04 AMD64 system with latest patches installed:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -fPIC -I. -I./ -I/tmp/pgsql-gis/build/postgresql-12.10/include/server -I/tmp/pgsql-gis/build/postgresql-12.10/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -c -o http.o http.c
http.c: In function ‘get_extension_schema’:
http.c:600:37: error: ‘ExtensionOidIndexId’ undeclared (first use in this function)
600 | scandesc = systable_beginscan(rel, ExtensionOidIndexId, true,
| ^~~~~~~~~~~~~~~~~~~
http.c:600:37: note: each undeclared identifier is reported only once for each function it appears in
http.c: In function ‘typname_get_tupledesc’:
http.c:636:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
636 | Oid typoid = GetSysCacheOid2(TYPENAMENSP, Anum_pg_type_oid,
| ^~~
http.c: In function ‘urlencode_jsonb’:
http.c:1499:4: warning: implicit declaration of function ‘getKeyJsonValueFromContainer’; did you mean ‘getIthJsonbValueFromContainer’? [-Wimplicit-function-declaration]
1499 | getKeyJsonValueFromContainer(&jb->root, key, strlen(key), &v);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| getIthJsonbValueFromContainer
make: *** [: http.o] Error 1

[pramsey]

Humbug, I guess I need to get CI building against old Pg versions again. It's such a pain.

[pramsey]

This builds cleanly back to 9.6, but I have not tested actual operation: 6bb9f52

[LeMerP]

Thank you very much for your fast fixing.