prash-wghats/Electron-VSCode-Atom-For-FreeBSD

chromium complie issues - Uses/execinfo.mk - not in recent ports trees

daviddpd opened this issue · 6 comments

daviddpd commented

Recent versions of the ports don't seem to have Uses/execinfo.mk

Checked out revision 446317.
+ cd chromium
+ rm files/patch-chrome_browser_ui_libgtkui_gtk_ui.cc
+ make configure 'DISABLE_VULNERABILITIES=yes'
make: "/usr/ports/Mk/bsd.port.mk" line 1485: Cannot open /usr/ports/Mk/Uses/execinfo.mk
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/dpd/Electron-VSCode-Atom-For-FreeBSD/electron/chromium

Removing execinfo - finds and undefined License.

===>  License not correctly defined: for unknown licenses, defining LICENSE_PERMS_MPL is mandatory (otherwise use a known LICENSE)
make[1]: exec(exit) failed (No such file or directory)
*** Error code 1

Things seem to go fine so far after that for chromium.

prash-wghats commented

Try make configure 'DISABLE_VULNERABILITIES=yes' 'LICENSE_PERMS_MPL=none' 'LICENSE_NAME_MPL=none' 'LICENSE_FILE_MPL=none'

indykish commented

Hey same problem. Is there anything else i need to do ?

[ram@ramwork:atom|master *%]$ ./build_atom.sh 
+ echo 'Building LIBCHROMIUMCONTENT ...'
Building LIBCHROMIUMCONTENT ...
+ svnlite co -r435428 svn://svn.freebsd.org/ports/head/www/chromium chromium
Checked out revision 435428.
+ cd chromium
+ patch -p1
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/files/patch-third__party_ffmpeg_ffmpeg__generated.gni	2017-12-07 09:29:02.987115000 +0400
|+++ b/files/patch-third__party_ffmpeg_ffmpeg__generated.gni	2017-12-07 09:29:52.859699000 +0400
--------------------------
Patching file files/patch-third__party_ffmpeg_ffmpeg__generated.gni using Plan A...
Reversed (or previously applied) patch detected!  Assume -R? [y] y
Hunk #1 succeeded at 23.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/Makefile	2017-12-07 09:26:24.600675000 +0400
|+++ b/Makefile	2017-12-07 09:27:50.794244000 +0400
--------------------------
Patching file Makefile using Plan A...
Reversed (or previously applied) patch detected!  Assume -R? [y] y
Hunk #1 succeeded at 15.
Hunk #2 succeeded at 43.
Hunk #3 succeeded at 185.
Hunk #4 succeeded at 229.
done
+ rm files/patch-third__party_ffmpeg_ffmpeg__generated.gni.orig
+ make configure DISABLE_VULNERABILITIES=yes LICENSE_PERMS_MPL=none LICENSE_NAME_MPL=none LICENSE_FILE_MPL=none
make: "/usr/ports/Mk/bsd.port.mk" line 1466: Cannot open /usr/ports/Mk/Uses/execinfo.mk
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/ram/code/rioos/Electron-VSCode-Atom-For-FreeBSD/atom/chromium
indykish commented

I am on FreeBSD 11.1.p9

[ram@ramwork:atom|master *%]$ sudo freebsd-update fetch
src component not installed, skipped
Looking up update.FreeBSD.org mirrors... 3 mirrors found.
Fetching metadata signature for 11.1-RELEASE from update5.freebsd.org... done.
Fetching metadata index... done.
Inspecting system... done.
Preparing to download files... done.

No updates needed to update system to 11.1-RELEASE-p9.
dch commented
indykish commented

Thanks for your comment.

This issue is helpful.

Additionally I did,

1. Portsnap update

I did a

portsnap fetch
portsnap update

FreeBSD portsnap link

portsnap updated

2. Edit chromium/Makefile

Since i had a prior run, my chromium dir was intact.


cd  Elect*/atom/chromium

ee Makefile

Search execinfo in chromium/Makefile using ee

Execinfo removed from Makefile

3. Ran build_atom.sh

cd  Electron*/atom

sudo ./build_atom.sh

Its building now (for a while).

sfourman commented

This also needs to be applied to electron/chromium/Makefile
The license also needs to be fixed

|--- a/content/browser/BUILD.gn 2018-03-04 11:24:27.565814000 +0400
|+++ b/content/browser/BUILD.gn 2018-03-04 11:19:56.545315000 +0400

Patching file content/browser/BUILD.gn using Plan A...
Hunk #1 succeeded at 28.
done

  • rm patches/third_party/skia/003-freetype-2.patch
  • rm patches/third_party/swiftshader/001-gold_ifc.patch
  • script/update -t x64 --skip_gclient
    Warning: No ".patch" files found in the "/usr/home/sfourman/Electron-VSCode-Atom-For-FreeBSD/electron/libchromiumcontent/patches/third_party" folder.
    Warning: No "    .patch" files found in the "/usr/home/sfourman/Electron-VSCode-Atom-For-FreeBSD/electron/libchromiumcontent/patches/third_party/swiftshader" folder.
    Traceback (most recent call last):
    File "script/update", line 397, in
    sys.exit(main())
    File "script/update", line 86, in main
    run_gn(target_arch, args.defines))
    File "script/update", line 336, in run_gn
    subprocess.call([gn, 'gen', os.path.relpath(output_dir, SRC_DIR), '--args=' + args],
    UnboundLocalError: local variable 'gn' referenced before assignment