build_atom.sh gives error: 'llvm_version' is not defined
TELunus opened this issue · 2 comments
At line 65 of build_atom.sh when it runs node's ./configure it errors telling me
gyp: name 'llvm_version' is not defined while evaluating condition 'llvm_version < "4.0"' in /files/fileroot/Projects/Freebsd-Atom/Test/atom/node/node.gyp while trying to load /files/fileroot/Projects/Freebsd-Atom/Test/atom/node/node.gyp (I realise the paths there don't have the repository name like they normally would, but that's because I copy out of the repository to my own working directory to try to get it to build)
I think the issue is that line 40 of ./configure sets the compiler to gcc except on OSX, which results in llvm_version not getting added to variables on line 668, meanwhile line 418 of node/common.gypi expects to evaluate the expression 'llvm_version < "4.0"' on any freebsd computer.
This seems like it might be more of a node issue than an issue of this port, except that I'm confused as to how anyone has managed to run build_atom.sh successfully. Since Freebsd isn't OSX ./configure will always set the compiler to gcc, and never set llvm_version, and common.gypi will always fail to evaluate 'llvm_version < "4.0"'
There was typo in node version selection in build_atom.sh line 64.
https://github.com/prash-wghats/Electron-VSCode-Atom-For-FreeBSD/commit/b26623f8f618175833424d9ec806133ad7ff4dab#diff-a6e1547933699b4f063514400493e56d