Clean up the code

Question

Clean up the code

Closed this issue 4 years ago · 10 comments

prashantsengar commented 5 years ago

The first step towards great code is clean code.

Let's start by cleaning up the code. You will require basic Python knowledge and PEP guidelines. (know what is PEP 8 )

Make the code more efficient, and more modular.

sid779 commented 5 years ago

Thanks

chavarera commented 5 years ago

ok

Answer 1 · 2019-12-06T14:12:28.000Z

I would like to do this. Please assign it to me.

Answer 2 · 2019-12-07T14:42:43.000Z

I ran the arrange.py once for weak arrange but none of the folders were created.
After running once it is giving file already exists error while I'm not able to see any folders anywhere.
Traceback (most recent call last):
File "arrange.py", line 15, in <module>
makeFolders('pPDF')
File "arrange.py", line 13, in makeFolders
os.mkdir(f'.\\{f}')
FileExistsError: [Errno 17] File exists: '.\\pPDF'
What if there are no files in the folder(in my case) what will be its behaviour.

Answer 3 · 2019-12-08T11:22:25.000Z

@sid779 it was a small error because I was writing it in Windows. It will be fixed by very soon

Answer 4 · 2019-12-08T11:40:02.000Z

I would like to do this.

Answer 5 · 2019-12-08T12:32:56.000Z

@chavarera this issue is being worked on by @sid779 and someone else too. If you'd like, you can choose other issues to work on or create a new issue.

Answer 6 · 2019-12-08T14:55:30.000Z

As @chavarera already created a pull request and did the work required I'll unassign myself. Please merge the pull request.

Answer 7 · 2019-12-09T19:58:43.000Z

why @prashantsengar not merging pull requests

Answer 8 · 2019-12-09T20:55:51.000Z

He will eventually, just relax and try to resolve other issues.