Shift Entire Codebase from ES5 to ES6.

Question

Shift Entire Codebase from ES5 to ES6.

Closed this issue 5 years ago · 7 comments

The codebase should be updated to use ES6 features. The current codebase is mixed with ES5 and ES6 syntax and practices.
The following needs to done

Change all usages of 'var' keyword with 'let' or 'const'.
Using promises instead of callbacks.

Answer 1 · 2019-10-06T16:04:53.000Z

I am not seeing anything which can be changed to ES6 promises

Answer 2 · 2019-10-06T18:45:24.000Z

Callback functions are being used in the Chrome API, we can change them to promises.

Answer 3 · 2019-10-06T20:36:48.000Z

Hi, can i work on this?

Answer 4 · 2019-10-07T02:15:04.000Z

Thanks for that @shikharsaxena98

Answer 5 · 2019-10-09T07:43:29.000Z

Is this issue closed? Can I work on it?

Answer 6 · 2019-10-09T10:39:29.000Z

@darkmatter18 & @wale-bant , I think @kohli6010 is working on this, else you can work on this.

Answer 7 · 2019-10-16T14:19:16.000Z

@shikharsaxena98 I don't think Chrome API is available in Promises so as to maintain backward compatibility. I tried to move to promises but the extension keeps on throwing errors. Although there are a few places where var is used and function()s have been defined.

https://stackoverflow.com/questions/42191030/promise-support-for-chrome-extensions-api

Another thing that could be done is to use babel to compile the code to ES5