prateekbh/babel-esm-plugin

Built in webpack modes have no effect

Closed this issue · 6 comments

prateekbh commented

While default bundles are auto minified by webpack --mode=production. Files generated by this are not.

Also webpack --mode=development have no effect on output

evenstensberg commented

Does it have the same behaviour when adding mode to the config itself?

prateekbh commented

Ummm I haven't tried that

evenstensberg commented

Just trying to triage and see if the bug is on us

prateekbh commented

Actually even running just webpack defaults to production mode right?

I don't think its a thing with flag or config its just childCompiler is skipping something

prateekbh commented

@ev1stensberg I tried adding

 childCompiler.options.plugins.push(new UglifyJsPlugin());

after: https://github.com/prateekbh/babel-esm-plugin/blob/master/src/index.js#L18

still doesn't minify... any idea why?

prateekbh commented

Apparently this was due to the effect that I changed extension from .just to .mjs

Fixed it by keeping default file names as blah.es6.js