Bump aiofiles dependency

Question

Bump aiofiles dependency

Luc1412 opened this issue 2 years ago · 13 comments

Describe the solution you'd like

Some months ago I PRed #181 to support newer version of aiofiles. Since then they switched from normal versioning to versioning which includes the year eg. 22.1.0 .

I'm not fully sure how they handle breaking changes, but it would be nice to implement some solution which allows users to use newer aiofiles version.

Describe alternatives you've considered

No response

Additional context

No response

Answer 1 · 2022-10-25T03:36:20.000Z

Bumping the version isn't going to have any impact unless you're using the deprecated token manager utilities.

Answer 2 · 2022-10-25T15:49:06.000Z

Bumping provides devs who use this wrapper + aiofiles the ability to use newer versions of aiofiles in their project as the version is currently locked at < 1

Answer 3 · 2022-10-25T22:46:03.000Z

Ah that's right. Feel free to open a PR to bump the version if you'd like.

Answer 4 · 2022-10-26T06:42:59.000Z

Not entirely sure how to pin the version, as they didn't stated anything when they introduce breaking changes.

Any idea whether to just pin it to <= latest or something like < 23

Answer 5 · 2022-10-28T14:16:29.000Z

Typically we pin to latest minor of the current version i.e., aiofiles==23.*. aiofiles<23 will also work but the former will ensure the latest version instead of any version below 23.

Answer 6 · 2022-11-27T18:06:57.000Z

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 30 days.

Answer 7 · 2022-12-27T18:07:08.000Z

This issue was closed because it has been stale for 30 days with no activity.

Answer 8 · 2023-10-20T09:44:56.000Z

Could this be reopened?

Answer 9 · 2023-10-20T14:01:29.000Z

Sure! Is there something that aiofiles added or uses that would make the newer version better?

Answer 10 · 2023-12-18T22:03:58.000Z

Sure! Is there something that aiofiles added or uses that would make the newer version better?

Hi @LilSpazJoekp, I have another package with a dependency on a later version of aiofiles. Has this been fixed in the last release? I'm still seeing asyncpraw is locked <1.

Answer 11 · 2023-12-18T22:06:56.000Z

The dev version is not pinned. We haven't pushed a new version yet however.

Answer 12 · 2023-12-18T22:48:29.000Z

The dev version is not pinned. We haven't pushed a new version yet however.

Thanks @LilSpazJoekp! I couldn't find a dev branch. Any ETA for new version?

Answer 13 · 2023-12-18T22:50:16.000Z

The master branch is the dev branch. You can install it with this command:

pip install --upgrade https://github.com/praw-dev/asyncpraw/archive/master.zip

Any ETA for new version?

No ETA right now.