prebid/prebid.github.io

topics module doc

Closed this issue · 5 comments

The topics module is documented here

#### Topics Iframe Configuration
but also needs a stand alone page

Hi @patmmccann @dgirardi ,

Along with stand alone page, We also need checkbox for Topics Module on download page. Currently it is missing and due to which we are not able to package Topics Module in prebid.js file.

Please find below screenshot of download page of prebid docs. (Currently it has First Party Data Enrichment and First Party Data Validation Checkbox but no checkbox for Topics Module)

image

Is there any specific reason we didn't add stand alone page(MD file) and option of Topics Module on download page?

Thanks.

hi @nitin0610

unfortunately #4222 documented the topics module on the publisher api not tot its own page. Could you PR moving this doc into its own module page? This is also why it doesnt show up on the download page. Check out other module initial doc releases for examples.

Hi @patmmccann ,

I have raised the PR prebid/Prebid.js#9484 as suggested.

Thanks

@nitin0610 you should pr this repo with the topics.md file, not just prebid.js repo, for the module to appear on the download website

Hi @patmmccann , Thanks for clearing out the confusion.

Please find below PR link. Can you please review it.
#4321

Do we still need this PR prebid/Prebid.js#9484 since md file is missing for topics module in prebid.js repo as well. I guess we can merge this as well. Let me know otherwise or we can close the PR directly if we don't require it.

Thanks.