140 issues on fresh clone
Closed this issue · 14 comments
On a fresh clone and npm install I am seeing the following output after npm start
[at-loader] Checking finished with 140 errors
All of the errors are apparently @types/lodash. I have another previously cloned copy of this project with changes working fine without these errors. Screenshot of part of the console below:
What could be going wrong? Do I have the wrong version of something globally?
No, you are not. Count to 5 and fresh clone again.
Okay, I just re-cloned and am seeing the same issue. Is there a reason you believe I'm not seeing these errors?
you didn't count to 5!
Try again. There was some params on tsconfig that are quite aggresive.
@Foxandxss I was confused for a second! lol.
Sadly, the config updates doesn't seem to have gotten rid of the errors for me. It's almost like I have wrong versions of something installed globally
for the sake of trying, could you bump typescript to 2.1.5?
Thank you for your speedy responses. Seems to have fixed it!
[at-loader] Checking started in a separate process...
[at-loader] Ok, 2.01 sec.
Will bumping this to 2.1.x cause any other issues? I saw in another issue that you said there are some incompatibilities between Angular and 2.1.x
Yes, AOT + TS2.1 is a no-no.
I just created a conversation around this issue at the angular slack.
Okay, cool. So should I not proceed with 2.1.5 and wait? Ignore those errors? I can't seem to find a previous commit that works on a fresh clone (even though my previous project is OK), and I'm confused about what is throwing those errors
@Foxandxss this appears to be a regression introduced upstream: DefinitelyTyped/DefinitelyTyped#13994
More discussion in another issue: DefinitelyTyped/DefinitelyTyped#14338
Running the command npm install @types/lodash@4.14.50 immediately fixed all issues for me with a fresh clone of this project (using Typescript 2.0.10)
As someone else pointed out, it's a bummer that a small patch level semver issue causes this issue and requires TS 2.1 or to manually roll back to 4.14.50.
Maybe for now, it's worth locking @types/lodash@4.14.50 in package.json until it's safe to bump TS to 2.1.x
Did removing the tsconfig options help? A shame that we can't use those to prohibit unused names. The console screen shot above seems to point to the lodash typings being too new (the 'no-no' 2.1) which I believe is a different issue than the compiler options.
No @GaryB432 tsconfig wasn't the issue here. It is @types/lodash@4.14.51 causing the issue by introducing TS 2.1 features. Since we have 2.0.10 here, of course we'll see many errors.
If you do a fresh clone, you have to manually roll back to @types/lodash@4.14.50 to get the errors to stop (safe version of @types/lodash without 2.1 features).
It also looks like Angular is working on landing a 2.1 support PR here so hopefully this all gets ironed out and TS can just get bumped to 2.1.x in the next week or so.
I just really like those compiler options and if they stay removed from master here, even though not causing a problem, I'll just have to maintain my own branch which is a minor inconvenience that I have not had to take yet.
Yeah, I did wrong. Open a PR and rererevert it. Too many things erroring today
Just went ahead and added the tsconfig changes back into the PR I just opened. This PR also locks the @types/lodash version properly to avoid any errors. I will keep a close eye here and submit any additional PRs needed as changes happen upstream :)