Integrate another starter in your starter

Question

Integrate another starter in your starter

Opened this issue 8 years ago · 10 comments

Hi,

I've been working on https://github.com/frederikprijck/angularjs-webpack-starter as part of my own setup for a while now.
There's a few differences compared to your starter, any chance you're up for a chat to see if we can integrate some features? I do get there's a lot of starters out there, so if my repo is totally not something you feel comfortable with, I'd totally understand!

Few things I'd prefer in a AngularJS starter these days (as it's all about getting people familiar with the Angular way of doing things to easier shift towards Angular):

TypeScript & @types
TS Lint
Components
SCSS
Webpack chunks
ngAnnotate

I'd be happy to send over a PR to integrate some things if you feel comfortable with it.

Note: I do get it's more interesting to focus on Angular instead of AngularJS these days. However, I think it's not a bad idea to get people more and more familiar with how Angular works (TS, Components, WebPack)

Note2: I'm talking about moving (some of) my things into your repository, not the other way around! :D

Answer 1 · 2017-08-08T09:07:30.000Z

hi @frederikprijck ,
right now i have no time to upgrade this starter kit but if you want to send a PR i will be very happy to review it and eventually merge it! 🙌

Answer 2 · 2017-08-08T09:15:41.000Z

@phra Before taking any time to create a PR, it might be good to know if you're interested in going for TS. If not, I can leave out that part (however, I'd encourage using TS), but that's a little bit more rework if you decide to not merge the TS version (which would be somewhat pitty for the time spent :D ).

Answer 3 · 2017-08-08T09:20:20.000Z

i work most of my time with typescript and i love it.
we can have a separate branch called typescript or merge it in master and move the actual one to a branch called javascript so in any case your work won't be useless.

what is @Foxandxss thinking about this?

Answer 4 · 2018-03-08T13:59:01.000Z

Hi @phra

Not sure where you got to with this, but I was wondering if you'd be interested in a pull request to add a basic component and karma tests.

Answer 5 · 2018-03-08T14:49:41.000Z

@jozzhart Not sure how this is related to the current issue (not saying it's not interesting tho, components & tests is interesting for sure! ) .

Never the less I'm still interested to incorporate https://github.com/frederikprijck/angularjs-webpack-starter in this repo. This one is almost on webpack 4 aswell. However, still awaiting feedback.

Using TypeScript will eventually make it easier to integrate with ngUpgrade to eventually move way from AngularJS and use Angular. We've even used my repo to give a talk regarding ngUpgrade and did a live coding session to upgrade the starter setup to Angular (using ngUpgrade) and incorporate it with angular-cli.

I could do a PR and have it reviewed. But I guess it's easier to have a look at my repo and let me know if you're interested in how things are done. Coz it'll change alot of the current setup.

Answer 6 · 2018-03-12T23:04:21.000Z

if you can work a PR that does:

update deps (update webpack / angular)
update and port to typescript the current components
update the tests

keeping the same UI of starter i would be glad to review the PR.

Answer 7 · 2018-07-05T10:58:08.000Z

hi @frederikprijck I'm looking for a AngularJS+Webpack+TS+SCSS starter, and the 2 most starred are this one and yours

I've cloned and installed both

this one seems faster, but yours is closer from my final goal

what way should I go?

thanks :)

Answer 8 · 2018-07-05T11:03:39.000Z

@cvaliere Feel free to report an issue on mine to indicate how you measure the speed.
I'd be happy to fix it.

Answer 9 · 2018-07-05T11:45:18.000Z

very simply: after starting your projects, I change a file (JS for this one, TS for yours) and I wait for reload
this one is almost immediate to reload, whereas yours takes a few seconds
I'm thinking that maybe it's because yours has 1 more step (compile TS to JS), but I didn't dive deep yet

anyway, as I see that you wanted to merge yours into this one, my question was: do you feel that this one is better for any reason? or should I go with yours (in which case I'd be happy to know what takes so long to reload, if you have any idea abou it)?

Answer 10 · 2018-07-05T11:50:50.000Z

I prefer mine, as that's why I've created it (it uses TypeScript, Webpack4, ...). But I don't like to pull people towards my repository in another person's repository, that's not done imho. If you want to dicsuss my repository, please open an issue in the repo and I'll be happy to help you / resolve issues.