predixdesignsystem/px-alert-message

Message truncation is not dynamic

Closed this issue · 1 comments

katemenkhaus commented

The expected behavior is that the button 'show more' would only show on alert messages that have text longer than 3 lines.

  1. Open new-demo branch and run the demo.
  2. select 'long message' tab
  3. select other tab and the 'show more' button does not disappear

Branch new-demo

Expected:
screen shot 2017-02-08 at 10 21 10 am

Bug:
screen shot 2017-02-08 at 10 21 01 am

possible problem:
We suspect that there are life-cycle issues with when _checkMessageLength function is being called/implemented. https://github.com/PredixDev/px-alert-message/blob/master/px-alert-message.html#L352

randyaskin commented

Fixed in v0.9.2.