Regression in localization behavior change causes component to fail
Closed this issue · 1 comments
Looks like 076be13 may have introduced a regression in the localization behavior that causes the component to fail to load in some browsers. (Failing tests here.)
@benoitjchevalier or @randyaskin - could either of you take a look when you have a chance? Think you two have been deep into the localization switch, right? Thanks.
Expected behavior and actual behavior:
Component should load correctly in Safari. Right now it fails to load because of a thrown TypeError coming from the _computeLocalize method.
Steps to reproduce the problem:
Open the px-alert-message demo page in Safari 9 or Safari 10. The page will fail to load correctly and an error will be logged to the console:
Environment:
- Mac OS X 10.11.6
- Safari 9.1.2
- px-alert-message v0.9.6
Have you tried blasting the bower components? I think the safari 9 issue has been fixed in app-localize-behavior > 1.0.0: PolymerElements/app-localize-behavior#92
The tests were genuinely failing for changing the "show more/show less" button so I've fixed that as well.