preservim/vim-colors-pencil

Support for tree-sitter?

lourenci opened this issue · 9 comments

The title speaks for itself.

Thank you for the colorscheme, I think it's the best light one out there.

I looked around a little bit. What tree-sitter has to do with colorscheme? Do you have any example of colorscheme that supports tree-sitter?

OK I found one. If you are using tree sitter you can test this color scheme with similar change to this one Iron-E/nvim-highlite@8c0162d and create PR.

The colorschemes could leverage the treesitter to keep the colors consistency between the groups, take a look at this. Not to mention that we could ditch polyglot, yats... plugins.

There are already some colors using it.

That's fine. If you are using treesitter you are the best person to add support to it ;-)

I'll try it.

I'd be happy to facilitate inclusion of a PR that adds whatever group aliasing is needed for tree-sitter support.It does seem kind of backwards though to generate a bunch of non-standard group names and expect color schemes to adapt. Wouldn't it make more sense to have a tree-sitter option to just alias all the groups to standard names that every color scheme out there already supports?

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

You hit the nail on the head. :)

If that's what's going on, then fair enough. Like I said I'm quite happy to see it facilitated from the color scheme end if that's what needs to happen, and if somebody contributes the leg work to figure out the right groups to add I'll help get it merged.