pret/pokegold

Some sources are not included in the build

rtandy opened this issue · 3 comments

rtandy commented

The following sources appear to not be used in the build.

  • data/pokedex/entries_crystal.asm
  • data/pokedex/entry_pointers.asm
  • data/pokedex/order_alpha.asm
  • data/pokedex/order_new.asm
  • data/pokemon/base_stats.asm
  • data/pokemon/base_stats/*.asm
  • data/pokemon/egg_move_pointers.asm
  • data/pokemon/egg_moves.asm
  • data/pokemon/evos_attacks.asm
  • data/pokemon/evos_attacks_pointers.asm
  • data/pokemon/names.asm
  • data/sprite_engine.asm
  • data/wild/fish.asm
  • data/wild/johto_grass.asm
  • data/wild/johto_water.asm
  • data/wild/kanto_grass.asm
  • data/wild/kanto_water.asm
  • data/wild/swarm_grass.asm
  • data/wild/swarm_water.asm
  • engine/sprite_anims.asm
  • engine/sprites.asm
  • engine/sprites_dump.asm
  • gfx/pics/animation.asm
  • gfx/pics/anim_pointers.asm
  • gfx/pics/anims.asm
  • gfx/pics/bitmask_pointers.asm
  • gfx/pics/bitmasks.asm
  • gfx/pics/extra_pointers.asm
  • gfx/pics/extras.asm
  • gfx/pics/frame_pointers.asm
  • gfx/pics/johto_frames.asm
  • gfx/pics/kanto_frames.asm
  • gfx/pics/pic_pointers.asm
  • gfx/pics/trainer_pic_pointers.asm
  • gfx/pics/unown_anim_pointers.asm
  • gfx/pics/unown_anims.asm
  • gfx/pics/unown_bitmask_pointers.asm
  • gfx/pics/unown_bitmasks.asm
  • gfx/pics/unown_extra_pointers.asm
  • gfx/pics/unown_extras.asm
  • gfx/pics/unown_frame_pointers.asm
  • gfx/pics/unown_frames.asm
  • gfx/pics/unown_pic_pointers.asm
  • gfx/pics/*/anim0.asm
  • gfx/pics/*/anim1.asm
  • gfx/pics/*/bitmask.asm
  • gfx/pics/*/frames.asm
  • home/double_speed.asm
  • home/mobile.asm
  • macros/event.asm
  • macros/sound.asm
  • maps/GoldenrodDeptStoreRoof.asm

Full list obtained via:

# top-level sources listed in Makefile
toplevel='audio.asm data/text/common.asm data/pokemon/dex_entries.asm wram.asm main.asm home.asm'
for asm in $toplevel; do echo "$asm"; python scan_includes.py "$asm"; echo; done | tr ' ' '\n' | sort -u > includes
git ls-files | grep '\.asm$' | sort -u > sources
comm -23 sources includes
entrpntr commented

As of the changes in #30, the list is down to:

  • data/collision_permissions.asm
  • data/sprite_anims/framesets.asm
  • engine/gfx/sprite_anims.asm
  • engine/gfx/sprites.asm

Other files not included/incbinned, despite extensions suggesting they should be:

  • gfx/overworld/chris_fish.2bpp
  • gfx/overworld/cut_grass.2bpp
  • gfx/overworld/cut_tree.2bpp
  • gfx/overworld/headbutt_tree.2bpp
  • gfx/tilesets/house.pal
  • gfx/tilesets/ice_path.pal
  • gfx/tilesets/radio_tower.pal
  • macros/legacy.asm

(Added a utility script tools/unused_sources.sh to keep track of this.)

  • 👍1
entrpntr commented

As of this commit, the only remaining file not included in the build is macros/legacy.asm (I have that commented out currently, because I'm not sure if there's a argument to support people porting legacy pokecrystal scripts to pokegold). Everything else has been removed, and the legacy macros are a different issue altogether, so I think this can be closed.

rtandy commented

Awesome. Thanks for working on it!