Fix up save nomenclature
Opened this issue · 1 comments
luckytyphlosion commented
It makes no sense. There are four structs: SaveArrayHeader, SaveArrayFooter, SaveChunkHeader, SaveChunkFooter. SaveChunkHeader isn't even defined in the same place as SaveChunkFooter.
static void CreateChunkFooter(SaveData *saveData, void *data, int idx, u32 size) {
struct SaveArrayFooter *footer;
footer = (struct SaveArrayFooter *)((u8 *)data + size);
footer->magic = SAVE_CHUNK_MAGIC;
footer->saveno = saveData->lastGoodSaveNo + 1;
footer->size = size;
footer->idx = idx;
footer->crc = GF_CalcCRC16(data, size + offsetof(struct SaveArrayFooter, crc));
}
The function is named CreateChunkFooter
yet it doesn't even use SaveChunkFooter
.
Probably a bunch of other stuff, I could spend 15 minutes and find more inconsistencies but I don't think it's necessary to point out more stuff.
red031000 commented
makes sense to me 🥺