Decide on name-formatting for move constants

[lhearachel]

Modern canonical names vs gen4 names, e.g.:

#define MOVE_VISE_GRIP
#define MOVE_FEINT_ATTACK
#define MOVE_SMOKESCREEN
#define MOVE_SMELLING_SALTS

vs.

#define MOVE_VICE_GRIP
#define MOVE_FAINT_ATTACK
#define MOVE_SMOKE_SCREEN
#define MOVE_SMELLING_SALT

Canonical list of modified moves.

[lhearachel]

For additional context, pokeemerald uses a mix (MOVE_THUNDER_PUNCH vs. MOVE_VICE_GRIP).

[red031000]

this is a gen 4 game, we're going with gen 4 names

[lhearachel]

Just as a note, the repo currently uses modern names in the const definitions:

pokeheartgold/include/constants/moves.h

Line 15 in feacd38

#define MOVE_VISE_GRIP 11

[Kurausukun]

One vote for canonical/gen 4

[mid-kid]

Another vote for gen4

[adrienntindall]

I like whichever one the bottom is

[lhearachel]

Vote for canonical

[lhearachel]

I like whichever one the bottom is

Bottom is gen4.

[cbt6]

Prefer gen 4 names.

Just as a note, the repo currently uses modern names in the const definitions:

Sounds like a bug to me.