pretix/pretix-passbook

Naming of Maps API Key

pc-coholic opened this issue · 1 comments

The plugin has a setting to provide an API-Key for the geocoding-Feature.

('passbook_gmaps_api_key', forms.CharField(
label=_('Google Maps API key'),
widget=forms.PasswordInput(render_value=True),
required=False,
help_text=_('Optional, only necessary to find coordinates automatically.')
)),

I would like to reuse it in the Google Pay Passes plugin. While setting up the API-key for myself, I realized that calling the setting "Google Maps API key" might be confusing, as in reality we need a Key for the Geocoding API.

Should we perhaps change the label to "Google Geocoding API key"? The Google API-console is a little confusing at times, as it they call the API "Geocoding API", but sometimes show a Google Maps-Icon next to it.

Please let me know what you think - I would then piggyback on that decision and setting ;-)

Agreed!