prettier/prettier-eslint

Create react app on node 8 - installs eslint version v6.7.2 which fails - need 6.4.0

inspiraller opened this issue · 2 comments

Using Node 8

create app using create-react-app

npx create-react-app prettiertest --use-npm

install dependencies

cd prettiertest
npm i --dev eslint-config-prettier eslint-plugin-prettier eslint-plugin-react prettier prettier-eslint-cli

create - eslintrc.json

{
  "env": {
    "browser": true,
    "es6": true
  },
  "parser": "babel-eslint",
  "parserOptions": {
    "ecmaVersion": 8,
    "sourceType": "module",
    "ecmaFeatures": {
      "jsx": true,
      "modules": true
    }
  },
  "plugins": ["prettier", "react"],
  "extends": ["prettier", "eslint:recommended", "plugin:react/recommended"],
  "rules": {
    "prettier/prettier": "error"
  },
  "settings": {
    "react": {
      "version": "detetect"
    }
  }
}

create .pretterrc.json

{
  "trailingComma": "es5",
  "semi": false,
  "singleQuote": true
}

add script to package.json

  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
    "format": "prettier-eslint --write \"{,!(node_modules)/**/}*.{js,jsx}\""
  }

run script format

npm run format

Error

assertion error - 'basePath' should be an absolute path

on further inspection noticed on my version of node 10 I seem to have an older version of eslint installed which works - eslint@6.4.0

On node 8 version it has installed a new version eslint@6.7.2 which has resulted in the error above.

The problem gets fixed when manually installing eslint@6.4.0

npm i eslint@6.4.0 --save-dev

I've got the same problem with eslint version 6.7.2 and prettier-eslint-cli version 5.0.
You can see the error here: https://github.com/MeilleursAgents/react-mapbox-wrapper/pull/90/checks?check_run_id=335010861

EDIT: here is a workaround prettier/prettier-eslint-cli#205 (comment)

Stale issue