prettier/prettier-eslint

ability to capture (non-fixable) eslint errors/warnings?

gwhitney opened this issue · 5 comments

gwhitney commented

Versions:

  • prettier-eslint version: 13.0.0
  • node version: 16.13.12
  • npm (or yarn) version: npm 8.1.2

Problem description:

Currently, prettier-eslint explicitly discards errors/warnings about eslint rule violations, as it is focused just on amending code to be compliant where it can. But I use prettier-eslint-cli to run prettier-eslint automatically on save from my editor. In that use case, it would be convenient for such errors/warnings to be written to stderr -- if that happened, they would pop up in my editor when I saved a file, which would save a step of running eslint at the end to check for any unfixable problems.

Suggested solution:

Add an option to prettier-eslint to pass back eslint error/warning messages about rule violations, in addition to the amended code, so that prettier-eslint-cli could then (perhaps optionally) write those to stderr. (Note I have yet to file an issue about this on the prettier-eslint-cli repo because at the moment there's no way the information could be written to stderr, since prettier-eslint is not providing it.)

Thanks for considering.

JounQin commented

PR welcome

github-actions commented

Stale issue

gwhitney commented

Oh, sorry I let this get stale. Working on a PR now. As far as I can see, the interface of format cannot be changed: it takes a code string and a path name where that code nominally resides, and returns a code string. So the plan I am working on in the PR is to add another export, tentatively named analyze, which takes the same arguments but returns a simple object with keys output whose value is the same string as format currently produces, and messages with all of the messages produced in the generation of output, if any. If that doesn't sound like a good plan or you feel the naming should be different, please advise.

gwhitney commented

Confused why this is closed before #827 is merged?

gwhitney commented

With #827 closed (what else can I do to help fix this?), could this issue be re-opened? It has not been resolved, and it was judged "PR welcome" initially. My apologies for the long period between that invitation and the PR I submitted, but please let me know if there is anything I can do to move toward a solution for this issue. Thanks!