Error during the build on version 17.12.0

Question

Error during the build on version 17.12.0

DianaSolanoR opened this issue 7 months ago · 12 comments

Hello,

I just upgraded the library version to 17.12.0. I'm using the lara-cyan theme and I encountered the following error during the build:

Undefined variable.
21 │ outline-offset: $inputFocusOutlineOffset;
node_modules/primeng-sass-theme/theme-base/_mixins.scss 21:21 focused-input()
node_modules/primeng-sass-theme/theme-base/components/input/_autocomplete.scss 22:13
@import node_modules/primeng-sass-theme/theme-base/_components.scss 10:13
@import node_modules/primeng-sass-theme/themes/lara/lara-dark/cyan/theme.scss 13:9

It appears that the variable does not exist in the _variables.scss file of that theme. Could you please take a look?

Thank you very much and best regards.

Answer 1 · 2024-04-01T15:27:29.000Z

Hi, I have checked the file and exists the variable in the line 58

Did you upgrade your library?

Answer 2 · 2024-04-02T07:16:18.000Z

Hello,
The issue exists in the dark version of the theme, not in the light one.

Thank you

Answer 3 · 2024-04-02T09:02:22.000Z

Hello, The issue exists in the dark version of the theme, not in the light one.

Thank you

I have checked the dark and the line is included too:

Maybe I'm checking in the wrong place. Could you confirm @cetincakiroglu if this problem exists or if i'm in the correct file. If not tell me what is the file and I can make the PR

Answer 4 · 2024-04-02T10:29:47.000Z

Same issue here.

@SoyDiego it seems that what gets installed via NPM is not the same as the source files (both themes, version 17.12.0):

Perhaps an issue in your publish process?

Answer 5 · 2024-04-02T12:04:18.000Z

Same issue here.

@SoyDiego it seems that what gets installed via NPM is not the same as the source files (both themes, version 17.12.0):

Perhaps an issue in your publish process?

Are you using NPM to install it?
I think Primetek doesn't have a official package for that. Can you share the link?
Always I cloned the project and compiled my styles and then my final .css files I used in my projects.

Answer 6 · 2024-04-02T12:34:09.000Z

Indeed, I'm using NPM 10. And I thought I could simply install the primeng-sass-theme package to avoid doing that manually every time there is a new release:

"primeng-sass-theme": "github:primefaces/primeng-sass-theme#17.12.0",

But as I can see, there are some differences between the source code and the code that gets "installed" using NPM.

As I said, this was my initial idea to reduce the manual work in maintaining the theme in sync with PrimeNG. In fact, it seems I'm not the only one who wants to avoid this manual work: #62

Do you think this is something the PrimeNG team can have a look at? At least ensuring that installing via github:primefaces/primeng-sass-theme#17.12.0 gets the same code as if we would manually download the ZIP file from https://github.com/primefaces/primeng-sass-theme/releases

Answer 7 · 2024-04-02T12:35:44.000Z

Maybe this PR makes it work? #113

Answer 8 · 2024-04-02T13:43:46.000Z

Digging a bit more into this, I think there is a mismatch in the tag 17.12.0 itself. I mean, checking the source code directly in that tag (https://github.com/primefaces/primeng-sass-theme/blob/17.12.0/themes/lara/lara-light/_variables.scss) , I can see that the variable $inputFocusOutlineOffset; is indeed missing:

And there is a newer commit in the main branch adding such missing variable: 07ee7cf

So I guess it's just matter or replacing the latest 17.12.0 release to point to the latest commit

Answer 9 · 2024-04-02T13:48:16.000Z

Indeed, I'm using NPM 10. And I thought I could simply install the primeng-sass-theme package to avoid doing that manually every time there is a new release:

"primeng-sass-theme": "github:primefaces/primeng-sass-theme#17.12.0",

But as I can see, there are some differences between the source code and the code that gets "installed" using NPM.

As I said, this was my initial idea to reduce the manual work in maintaining the theme in sync with PrimeNG. In fact, it seems I'm not the only one who wants to avoid this manual work: #62

Do you think this is something the PrimeNG team can have a look at? At least ensuring that installing via github:primefaces/primeng-sass-theme#17.12.0 gets the same code as if we would manually download the ZIP file from https://github.com/primefaces/primeng-sass-theme/releases

I'm not part of Primetek only a contributor but I think they are not interested (I don't remember why in create a NPM package, maybe i'm wrong, I don't know 100%).

Answer 10 · 2024-04-02T13:56:22.000Z

Digging a bit more into this, I think there is a mismatch in the tag 17.12.0 itself. I mean, checking the source code directly in that tag (https://github.com/primefaces/primeng-sass-theme/blob/17.12.0/themes/lara/lara-light/_variables.scss) , I can see that the variable $inputFocusOutlineOffset; is indeed missing:

And there is a newer commit in the main branch adding such missing variable: 07ee7cf

So I guess it's just matter or replacing the latest 17.12.0 release to point to the latest commit

If I understood ok, maybe they created the tag before this commit. Will see if generating a new tag, the problem is solved. We need to wait for Primetek team

Answer 11 · 2024-04-02T15:30:25.000Z

Yeah, that's right. Fortunately in the meantime I can simply add the commit hash to get the latest changes:

"primeng-sass-theme": "primefaces/primeng-sass-theme#07ee7cfd98df828a9bdd31eb4f5424e700832409"

Answer 12 · 2024-04-02T15:35:31.000Z

Yeah, that's right. Fortunately in the meantime I can simply add the commit hash to get the latest changes:

"primeng-sass-theme": "primefaces/primeng-sass-theme#07ee7cfd98df828a9bdd31eb4f5424e700832409"

That's good alternative idea at the moment. Thanks for share it