primer/brand

🐛 [BUG] - Escaped characters appearing in compiled CSS output

Closed this issue · 1 comments

rezrah commented

Describe the bug

Special characters are being unintentionally escaped in the compiled CSS stylesheet (main.css).

Example:

Source Compiled

Source code for river story scroll featuring a plus character

(Source)

Same CSS rule but as compiled output in unpkg

(Source)

Originally reported by @dgreif in Primer Brands slack channel

Reproduction steps

1. Go to https://unpkg.com/browse/@primer/react-brand@0.42.1/lib/css/main.css and scroll down to styles for RiverStoryScroll
2. Observe that special characters are being escaped in contrast [the source code](https://github.com/primer/brand/blob/281beb08114f24f0ec5b23b14643324b0be532e6/packages/react/src/river/RiverStoryScroll/RiverStoryScroll.module.css#L150-L152)

Expected behavior

Special characters shouldn't be escaped in compiled output

Browsers

No response

OS

No response

rezrah commented

@dgreif this issue was resolved in this pr, with the fix shipped in this release.

Thanks for reporting the bug. Let us know if you encounter any other issues.

  • 🎉1