primer/octicons

The 16px `circle` icon is slightly mis-aligned

simurai opened this issue · 2 comments

Reported by @laserlemon in Slack

i just wanted to point out that the (new?) circle octicon doesn’t seem to actually be a perfect circle at the 16px size. see: https://primer.style/octicons/circle-16 vs https://primer.style/octicons/issue-opened-16. the top is flattened. 24px looks

I didn't really see it, but when taking a screenshot and then zooming in with "render pixels" in Sketch, it seems that the circle is slightly off center and maybe needs to be nudged a tiny bit?

Screen Shot 2021-04-05 at 22 55 19

It could just be how it’s rendered in primer.style but the flat spots on the top and left were clearer there:

Screen Shot 2021-04-05 at 10 04 35 AM

Strangely, this didn't close when #584 landed. I'd close it myself but I'm not allowed! 🙈