[Feedback] npm package contains duplicate icon data

Question

[Feedback] npm package contains duplicate icon data

xt0rted opened this issue 3 years ago · 16 comments

Describe the topic

I just installed v16.1.1 of @primer/octicons and noticed the svg folder and data.json file are duplicated in the package. I don't think this is intended and it's doubling the size of the package.

Answer 1 · 2021-11-22T14:13:13.000Z

Hi @xt0rted, thanks for letting us know! We'll take a look at this once we get some open bandwidth.

Answer 2 · 2022-05-21T15:02:48.000Z

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

Answer 3 · 2022-05-21T17:17:05.000Z

Still an issue in 17.2.0

Answer 4 · 2022-08-22T15:55:58.000Z

@jonrohan is this something you might be able to squeeze in this quarter?

Answer 5 · 2023-01-05T17:02:11.000Z

Following up, @jonrohan is this still an issue or can we close this?

Answer 6 · 2023-01-05T17:04:32.000Z

I think this is still an issue. I believe both data sources are in use, so we'd need to investigate which one we can remove and update any libraries using them.

Answer 7 · 2023-01-31T20:09:22.000Z

Hey @JoshBowdenConcepts, this might be a good one to pick up - thoughts?

Answer 8 · 2023-07-30T21:02:11.000Z

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

Answer 9 · 2023-08-07T15:42:50.000Z

Thank you for raising this issue, it is a known error and is in our backlog.

Answer 10 · 2023-12-15T11:57:37.000Z

Would you accept a PR? Sounds like a quick change. This bug doubles the size of the package

https://packagephobia.com/result?p=@primer/octicons@13.0.0

Answer 11 · 2023-12-19T16:27:55.000Z

Hi @fregante, thanks for the offer. Yes, we would gladly accept a PR for this change!

Answer 12 · 2023-12-20T03:20:04.000Z

@lesliecdubs done

Answer 13 · 2023-12-27T04:13:19.000Z

Thanks @fregante! ✨ We might be a little slower than usual with PR review due to the holiday season, but we should be able to get to it in the new year. Thanks for contibuting!

Answer 14 · 2024-03-13T05:01:20.000Z

This can be closed once #1010 is published to npm. We should see the halving of the package here: https://packagephobia.com/result?p=@primer/octicons

Answer 15 · 2024-03-27T16:24:13.000Z

Just wanted to confirm that I don't see this anymore in v19.9.0. Going to close this out as I believe it's been addressed, feel free to leave a comment if I'm getting something wrong here!

Answer 16 · 2024-03-27T16:43:07.000Z

Indeed in my link you can see the package going from 2.16 to 1.08, exactly half